Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix value prismatic ring #2520

Closed
wants to merge 1 commit into from

Conversation

jeswilldbm
Copy link
Contributor

The prismatic ring showed an erroneous value as it was not equipped, with this modification it would be fine.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behaviour

Actual

Currently the ring shows that it has 8% energy protection.

Expected

with the modification, the ring shows the correct value

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

It was tested by reviewing the statistics of the energy ring before equipping it and after equipping it and that they both maintain the correct value.

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

The prismatic ring showed an erroneous value as it was not equipped, with this modification it would be fine.
@jeswilldbm jeswilldbm closed this Apr 2, 2024
@jeswilldbm jeswilldbm deleted the fix-prismatic-ring branch April 2, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant